chore: add registry auth to docker image apps #4187
Conversation
|
I would like some input on this, I have some questions ex:
|
No it should only show like on GitHub actions for example -> Like REGISTRY_SECRET only show the env or so not the value
Yes please - all sensitive data needs to be encrypted (passwords tokens etc), very simple to implement thanks to Laravel
What issues are you facing, maybe DM me or open discussion on Discord |
OSINTRoach
force-pushed
the
docker-image-login
branch
from
71856c8
to
1d2d88e
Compare
OSINTRoach
force-pushed
the
docker-image-login
branch
from
1d2d88e
to
ebf2072
Compare
|
Thanks for taking the time to improve the PR. Overall the PR is coming along nicely.
If you need help with anything just let me know. |
peaklabs-dev
added
💤 Waiting for feedback
| try { | ||
| // setup | ||
| $this->dockerImage = $this->application->docker_registry_image_name; | ||
| if (str($this->application->docker_registry_image_tag)->isEmpty()) { |
There was a problem hiding this comment.
docker_registry_image_tag why do we call it docker registry image tag I think dockerImageTag will be sufficient as this is available on all repos (would be great if you could rename it.
| <div class="w-fit"> | ||
| <x-forms.checkbox wire:model.live="application.docker_use_custom_registry" | ||
| id="application.docker_use_custom_registry" | ||
| helper="Select a registry to pull the image from." label="Use Private Registry" /> |
There was a problem hiding this comment.
Please also add the private registry section to all git deploy types under docker image:
-> Somewhere down here (Nixpacks, docker Image and Dockerfile have this).
There was a problem hiding this comment.
One more thing: A dropdown is a bit limited, if you have docker hub and ghrc private images it should probably be a multiselect so you can select multiple private registries and these will be used.
There was a problem hiding this comment.
So you mean like if you would pull from or push to multiple registries from one deployment ? I think this would require a loop of logins for each reqistry, and might need some manipulation of tags since i think with multiple registries the tags have to have a prefix of url sort of like ghcr.io/user/app:latest and those for docker hub just /user/app:latest etc but i think its doable
There was a problem hiding this comment.
Please also add the private registry section to all git deploy types under docker image:
This might require a bit of time, not yet sure how other things are built/handled and how i would implement there, but probably doable. Its just this one was the most logical since its not connected to anything, its just plain docker image pulled from dockerhub, but now it can be pulled from wherever
|
|
I also found an Icon you can use, same one as in docker desktop: https://tablericons.com/icon/cube-3d-sphere. |
Changes