Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for bootstrap dark mode #5629

Open
4 tasks
abe-101 opened this issue Jan 9, 2025 · 1 comment
Open
4 tasks

Add support for bootstrap dark mode #5629

abe-101 opened this issue Jan 9, 2025 · 1 comment

Comments

@abe-101
Copy link
Contributor

abe-101 commented Jan 9, 2025

Description

Bootstrap 5.3 now supports a dark mode out of the box
https://getbootstrap.com/docs/5.3/customize/color-modes/#dark-mode

in the docs they provide example js that can be used to toggle btw light and dark mode: https://getbootstrap.com/docs/5.3/customize/color-modes/#javascript

I propose adding this to the template
steps that need to be taking:

  • add data-bs-theme="light" to base template
  • add theme-toggler.js to static/js/ with this js code
  • Source it in the base template
  • add toggle buttons to the nav menu

I would argue that we should just add this but one could argue it should be added as a feature flag, what are your thoughts?

@browniebroke
Copy link
Member

Sure, why not. I don't think it's worth the complexity of adding it as a template option and agree that "we should just add this" 👍🏻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants