-
Notifications
You must be signed in to change notification settings - Fork 794
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Jigsaw modules support #196
Comments
Bumping the minimal supported Java version to 11 is out of the question, given that its adoption is nowhere near universal. It would likely break many projects that already depend on Thumbnailator. Looking around, it looks like there are ways to target lower versions of Java with But in any case, supporting modules is not a high-priority at this point. If you need them right now, your option would be to use rely on tooling that can provide the necessary module descriptors that you want. |
Can you please at least add an automatic module name to the manifest? |
@torakiki, thanks, I will look into this :) |
I'll add an |
Just FYI, an |
Hello,
I'd like to use this library in one of my projects, though I noticed that it doesn't provide a module info. I was going to add one myself and create a PR, but as soon as I pulled the repo I noticed that the minimum version supported is Java 5. I'd still like to implement this feature and get it merged, so, if it's something that can be useful for the library, should I bump the minimum version to Java 11 or resort to some magic using moditect's plugin?
The text was updated successfully, but these errors were encountered: