Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pigeon Message Processing Life Cycle Events #241

Open
jleonardolemos opened this issue Nov 3, 2021 · 0 comments
Open

Pigeon Message Processing Life Cycle Events #241

jleonardolemos opened this issue Nov 3, 2021 · 0 comments
Labels
enhancement New feature or request

Comments

@jleonardolemos
Copy link
Collaborator

jleonardolemos commented Nov 3, 2021

Problem
Long running process with artisan commands just keep DB connections alive while it is running.
The problem can be easily fixed with a explicit call to DB::disconnect('connection-name'); but i need to add this to all commands.
This can be very dangerous because we can forget to add the code and because we need to edit existing code

Possible Fix
Pigeon could dispatch events to Laravel Event Bus before and after the message processing, then we can listen to this event in a classic Laravel Event listener.

Additional context
The resources kept open are very dangerous with blue green deployments just because we allocate 2x of resources for a few seconds while the container is being replaced to the new one.

@jleonardolemos jleonardolemos added the enhancement New feature or request label Nov 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant