You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Currently we have some problems with pigeon usage and testing
I propose this thread issue, for discussion, these are my points:
We can not call the methods in any sequence as a real fluid interface.
In order to allow call methods with fake driver we needed to duplicate some methods in different interfaces, maybe we need a declarer interface
A package shold not capture its own exceptions, it need to throw the exceptions, the apps can chose wich exceptions they will handle
A consumer is a blocking peace of code, the listener that contains the consumer will never return something, all handling will be inside the consumer callback. RPCs are ment to work as a method call, most of RPCs responses will be returned, this behavior forces us to use akward references and are intestables.
Testing RPCs does not works very well because currently they are consumers, consumers needs to be triggered after application code and rpc response stubs needs to be defined before application code.
We need to take care of some metrics like MSI and we should make sure that Pigeon will not block phpstan level 8 in order to allow everyone to use the package without decrease their app metrics and phpstan level
The packages dependencies should be resolved by container and pass to the package classes constructors, currently the entire container is being passed to the package as a single dependency.
The text was updated successfully, but these errors were encountered:
Currently we have some problems with pigeon usage and testing
I propose this thread issue, for discussion, these are my points:
The text was updated successfully, but these errors were encountered: