Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Thoughts for improvements maybe a 3.0 #126

Open
jleonardolemos opened this issue Apr 14, 2020 · 0 comments
Open

Thoughts for improvements maybe a 3.0 #126

jleonardolemos opened this issue Apr 14, 2020 · 0 comments
Labels
enhancement New feature or request

Comments

@jleonardolemos
Copy link
Collaborator

jleonardolemos commented Apr 14, 2020

Currently we have some problems with pigeon usage and testing

I propose this thread issue, for discussion, these are my points:

  1. We can not call the methods in any sequence as a real fluid interface.
  2. In order to allow call methods with fake driver we needed to duplicate some methods in different interfaces, maybe we need a declarer interface
  3. A package shold not capture its own exceptions, it need to throw the exceptions, the apps can chose wich exceptions they will handle
  4. A consumer is a blocking peace of code, the listener that contains the consumer will never return something, all handling will be inside the consumer callback. RPCs are ment to work as a method call, most of RPCs responses will be returned, this behavior forces us to use akward references and are intestables.
  5. Testing RPCs does not works very well because currently they are consumers, consumers needs to be triggered after application code and rpc response stubs needs to be defined before application code.
  6. We need to take care of some metrics like MSI and we should make sure that Pigeon will not block phpstan level 8 in order to allow everyone to use the package without decrease their app metrics and phpstan level
  7. The packages dependencies should be resolved by container and pass to the package classes constructors, currently the entire container is being passed to the package as a single dependency.
@jleonardolemos jleonardolemos added the enhancement New feature or request label Apr 14, 2020
@jleonardolemos jleonardolemos changed the title Thoughts for improvements maybe a 2.0 Thoughts for improvements maybe a 3.0 Nov 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant