Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: Drop isomorphic-fetch from implementation #214

Open
PSoltes opened this issue Sep 10, 2024 · 2 comments
Open

Feature request: Drop isomorphic-fetch from implementation #214

PSoltes opened this issue Sep 10, 2024 · 2 comments

Comments

@PSoltes
Copy link

PSoltes commented Sep 10, 2024

  • Node 16 is no longer maintained
  • Node 18 onwards includes fetch by default.
  • Thus isomorphic-fetch should be replaced by plain fetch (either from browser or node)

Benefits

  • significant reduction in bundle size as isomorphic-fetch uses node-fetch which is not smallest (2.6.1 version)[https://www.npmjs.com/package/node-fetch/v/2.6.1]
  • isomorphic-fetch is no longer maintained
@cs-raj
Copy link
Contributor

cs-raj commented Sep 11, 2024

Hi @PSoltes thanks for raising this we will be looking into the issue and implement the required change
cc: @netrajpatel

@PSoltes
Copy link
Author

PSoltes commented Sep 12, 2024

Thanks for considering this 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants