Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rolling restart ignores monitor-only label #2033

Open
jvkohler opened this issue Oct 2, 2024 · 1 comment
Open

Rolling restart ignores monitor-only label #2033

jvkohler opened this issue Oct 2, 2024 · 1 comment

Comments

@jvkohler
Copy link

jvkohler commented Oct 2, 2024

Describe the bug

Enabling rolling restarts with incompatible containers that include com.centurylinklabs.watchtower.monitor-only=true results in abort.

Steps to reproduce

  1. Set WATCHTOWER_ROLLING_RESTART=true in docker compose for watchtower
  2. Set label com.centurylinklabs.watchtower.monitor-only=true on containers with a service dependency, like something using gluetun.
  3. Start watchtower

Expected behavior

Rolling restart only analyses dependency chain of full update enabled containers

Screenshots

No response

Environment

containrrr/watchtower@sha256:e7dd50d07b86c380dd53caeb7778da052d1a8fc2c606644a419afa35e9f5691e
Docker 27.1.2 on x64 Debian Bookworm

Your logs

time="2024-10-01T23:24:14-06:00" level=debug msg="Sleeping for a second to ensure the docker api client has been properly initialized."

time="2024-10-01T23:24:15-06:00" level=debug msg="Making sure everything is sane before starting"

time="2024-10-01T23:24:15-06:00" level=debug msg="Retrieving running containers"

time="2024-10-01T23:24:15-06:00" level=error msg="\"/arr-flaresolverr\" is depending on at least one other container. This is not compatible with rolling restarts"

time="2024-10-01T23:24:15-06:00" level=info msg="Waiting for the notification goroutine to finish" notify=no

Additional context

No response

Copy link

github-actions bot commented Oct 2, 2024

Hi there! 👋🏼 As you're new to this repo, we'd like to suggest that you read our code of conduct as well as our contribution guidelines. Thanks a bunch for opening your first issue! 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants
@jvkohler and others