Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Non-label method for excluding containers #1566

Closed
rdamazio opened this issue Feb 16, 2023 · 1 comment · Fixed by #1784
Closed

Non-label method for excluding containers #1566

rdamazio opened this issue Feb 16, 2023 · 1 comment · Fixed by #1784

Comments

@rdamazio
Copy link
Contributor

Is your feature request related to a problem? Please describe.

On Synology (and I assume other environments - UniFi comes to mind), there are often "private" containers that we don't control the creation of. As a consequence, watchtower tries to update those but fails.

Since there's no way to update labels for those containers after they were created, and we don't create them, there's no good way to exclude them, short of

Describe the solution you'd like

I'd be happy with a --exclude or similar flag (possibly taking a regex?) to tell watchtower what to exclude - that's easy to update.

Describe alternatives you've considered

  • Using --label-enable is harder to manage (requires managing labels for all the other containers)
  • Creating derived containers just to add the label is not really an option for a lot of these private containers, especially as some of them have their own update mechanism.
  • On Synology specifically, updating environment variables is easier (doesn't require recreating the container), so that's definitely a good option there
  • There could simply be a flag to silently ignore any containers that aren't on the registry (would solve the Synology docviewer case, might not solve the UniFi case where they create common containers too)
  • A file with the list of exclusions might also work

Additional context

Related to #923 .

@github-actions
Copy link

Hi there! 👋🏼 As you're new to this repo, we'd like to suggest that you read our code of conduct as well as our contribution guidelines. Thanks a bunch for opening your first issue! 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant