Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(generic): extra data and custom headers #377

Merged
merged 2 commits into from
Aug 20, 2023
Merged

Conversation

piksel
Copy link
Member

@piksel piksel commented Aug 20, 2023

Add support for @header=value and $data=value query parameters for the generic service.

This also enables support for header-based authentication, i.e. by using ?@authorization=Bearer+TOKEN.

Fixes #365
Fixes #366

@codecov
Copy link

codecov bot commented Aug 20, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.21% 🎉

Comparison is base (f4d52db) 78.95% compared to head (52c041d) 79.17%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #377      +/-   ##
==========================================
+ Coverage   78.95%   79.17%   +0.21%     
==========================================
  Files         101      102       +1     
  Lines        4439     4485      +46     
==========================================
+ Hits         3505     3551      +46     
  Misses        756      756              
  Partials      178      178              
Files Changed Coverage Δ
pkg/services/generic/custom_query.go 100.00% <100.00%> (ø)
pkg/services/generic/generic.go 86.36% <100.00%> (+0.99%) ⬆️
pkg/services/generic/generic_config.go 94.44% <100.00%> (+0.32%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Generic Webhook: params code doesn't match docs Generic Webhook: Support arbitrary headers
1 participant