-
Notifications
You must be signed in to change notification settings - Fork 96
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
No support for fetching stats of all containers #239
Comments
@RazCrimson was this solved with your PR? (#237), or are there more bits to chase here? |
No, it not done. @TomSweeneyRedHat My earlier PR was on Would it be fine to raise a PR to add that? Also something else I noticed after I created this issue is that, there is no support to stream pod stats. The latest podman docs mentions that it supports live streaming for pod stats but the API endpoint doesn't accept any |
Thanks for the clarification @RazCrimson . FWIW, PR's are always gratefully accepted! |
@RazCrimson thank yo for your contributions! Did your PRs address this issue or is there still some work left? |
Current Scenario
podman-py
currently does not directly provide any means to fetch the stats of all containers.But this is allowed in as per the Podman REST API.
Note that the
containers
parameter can take in multiple IDs or no ID to return data for all containers.The current method that uses this API
Container.stats
does not allow such actions.Proposed Solution
I propose to add an additional
stats
method underContainerManager
that would optionally take in cointainer_ids and stream the results.Shall I go ahead and make a PR for this with the required changes or are there any other ways to implement this that would be considered better?
The text was updated successfully, but these errors were encountered: