fix: default json-file log size to 100MB #3670
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AkihiroSuda
reviewed
Nov 13, 2024
pkg/logging/json_logger.go
Outdated
| //maxSize Defaults to unlimited. | ||
| var capVal int64 | ||
| capVal = -1 | ||
| //maxSize Defaults to 100MB. |
There was a problem hiding this comment.
Where is this set to 100MiB?
How was this value chosen?
There was a problem hiding this comment.
100MB is the default value that go-logrotate specifies for each log file.
defaultMaxsize = 100
There was a problem hiding this comment.
Could you add that context to the code comment?
coderbirju
force-pushed
the
update-json-logger
branch
from
75c4c88 to
e97bfa8
Compare
AkihiroSuda
reviewed
Nov 18, 2024
pkg/logging/json_logger.go
Outdated
| capVal = -1 | ||
| // MaxBytes is the maximum size in bytes of the log file before it gets | ||
| // rotated. If not set, it defaults to 100 MiB. | ||
| // see: https://github.com/fahedouch/go-logrotate/blob/main/logrotate.go#L500 |
There was a problem hiding this comment.
"main" has to be replaced with an exact version or a commit hash for permanence
Signed-off-by: Arjun Raja Yogidas <[email protected]>
coderbirju
force-pushed
the
update-json-logger
branch
from
e97bfa8 to
1fdb4b0
Compare
|
Could this fix be backported to nerdctl 1.7.x, considering containerd 2.0 is not yet LTS. @AkihiroSuda @djdongjin |
AkihiroSuda
approved these changes
Nov 19, 2024
For nerdctl we do not have any LTS (yet) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#3661
This commit makes the json-file logger to default logrotate maxBytes configuration of 100MB.
It is a temporary fix to a bug addressed by this logrotate PR.
Setting the default values in the config passed to logrotate fixes the issue temporarily but having unlimited size for container logs will be available when the issue is addressed upstream.
Testing done :
Verified that the logging mechanism works and appends the logs to the same log file and doesn't create a new log file.