-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow all external download URLs to be aliased #1067
Comments
will do this after conversation to higher level, as it's much easier to implement in typescript. |
I need this within maximum 4 weeks :-/ I think longer term we should take all these URLs and proxy them ourselves through our own CDN/host so that the user only needs to alias one or a few URLs and not 10+ |
This comment was marked as resolved.
This comment was marked as resolved.
Is it sufficient to replace just base urls or will the entire url path need to be set, perhaps minus the artifact file name/ext? An alternate/simple way to test this is to add /etc/hosts entries for each default hostname to point back to localhost, vs actually blocking the outbound traffic. |
By base URL I'm not meaning only the host, I mean it could be like https://host.com/some/path too. Is that what you're worried about? |
Yes. Good deal.
…__________________________
Randy Geyer | Principal Solutions Architect, Mend | +1 214 926-4907 |
***@***.***
On Wed, Jun 21, 2023 at 12:44 AM Rhys Arkins ***@***.***> wrote:
Is it sufficient to replace just base urls or will the entire url path
need to be set, perhaps minus the artifact file name/ext?
By base URL I'm not meaning only the host, I mean it could be like
https://host.com/some/path too. Is that what you're worried about?
—
Reply to this email directly, view it on GitHub
<#1067 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ASV56G6L2IEPAAUNZAOVNBTXMKC4FANCNFSM6AAAAAAZI77INE>
.
You are receiving this because you commented.Message ID:
***@***.***>
|
The linked PR above will fix this issue for all tools beside the tools installed via Would it be enough to document how to use the specific package manager environment variables? Otherwise i would convert those tools and update the default registry urls on the fly, but that needs some more time to implement. |
I think those tools hopefully have their own way of using own registries. I was after examples of redirecting URLs like GitHub and downloads.apache.org |
will add the docs and also missing |
@viceice does this require any more code, or just docs? |
needs more code too |
please support redirect/replace in some company intranet,unable to access |
already supported |
when this build is done, we should have all tools compatible with url replace https://github.com/containerbase/base/actions/runs/5964382723 |
We should mention the abilllity to change the default corepack registry (can only be done at runtime) |
Some users need to build their own containerbase-derived images in their product environments which do not have direct internet access. Instead, they need to set up generic proxies on Artifactory for each distinct external host which is approved, such as github.com, nodejs.org, etc.
Here's some examples used by containerbase:
We can assume for now that such users can already redirect common registries like apt, npm, pip, etc - the primary concern is on arbitrary URLs like the above.
The best way to test this would be to have a build environment with external URLs blocked by default and then try to build a "full" image with all tools and find the missing URLs one by one.
The next thing we'd want is a simple way of defining alternative URLs using env.
One possibility would be to have a syntax where the full from/to is specified in separate, related variables. e.g.
URL_REPLACE_0_FROM=https://node.org
URL_REPLACE_0_TO=https://artifactory.company.com/something/nested
Such a syntax is verbose but then at least should cover every case.
A higher level approach would be like
JAVA_BASE_URL=https://artifactory.company.com/something/java
but has the downsides:Missing Tools
bundler
(gem
) feat(ruby): convert gem tools and add install-gem command #1355cocoapods
(gem
) feat(ruby): convert gem tools and add install-gem command #1355dotnet
feat(cli): convert dotnet #1347hashin
(pip
) 6b8670cpdm
(pip
) 6b8670cpip-tool
(pip
) 6b8670cpipenv
(pip
) 6b8670cpoetry
(pip
) 6b8670cThe text was updated successfully, but these errors were encountered: