-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix ClientUpdateProposal for IBC v3 #142
Comments
thanks for taking this one @hashedone ! let us know if you run into any blockers |
@daniellarita unfortunately more I am reading the code around, the less I am positive I have an idea of what to do. The gov proposals in tgrade are handled in https://github.com/confio/tgrade/blob/v1.0.1/x/twasm/contract/incoming_msgs.go#L61. There is no handler for For now, my best bet is - ClientUpdate should be changed to IBCClientUpdate and its structure should be aligned. I can do that. I will prepare PR for that, but if something should be understood differently please give me some lead. |
Thanks for the update! @alpe @pinosu can you provide @hashedone with some clarification/ feedback on if his approach makes sense? Thanks! |
The |
The the proposal content was changed and simplified!
ClientUpdateProposal https://github.com/cosmos/ibc-go/blob/main/proto/ibc/core/client/v1/client.proto#L43
The text was updated successfully, but these errors were encountered: