kernel: Add CONFIG_TMPFS_XATTR to tdx.conf #10790
Open
+5
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I will need support in defining the proper place for this setting as I've just naively set it for |
|
|
ksandowi
approved these changes
Jan 24, 2025
fidencio
reviewed
Jan 24, 2025
| @@ -10,3 +10,4 @@ CONFIG_VIRT_DRIVERS=y | |||
| CONFIG_X86_5LEVEL=y | |||
| CONFIG_X86_INTEL_MEMORY_PROTECTION_KEYS=y | |||
| CONFIG_X86_PLATFORM_DEVICES=y | |||
| CONFIG_TMPFS_XATTR=y | |||
There was a problem hiding this comment.
@JakubLedworowski, please, create a new file under https://github.com/kata-containers/kata-containers/tree/main/tools/packaging/kernel/configs/fragments/common/confidential_containers and add this there.
During pull inside the guest, overlayfs expects xattrs. Fixes: [guest-components#876](confidential-containers/guest-components#876) Signed-off-by: Jakub Ledworowski <[email protected]>
JakubLedworowski
force-pushed
the
add-xattr-to-confidential-kernel
branch
from
252bc4f to
203785f
Compare
fidencio
reviewed
Jan 24, 2025
| @@ -293,6 +293,9 @@ get_kernel_frag_path() { | |||
| info "Enabling config for '${conf_guest}' confidential guest protection" | |||
| local conf_configs="$(ls ${arch_path}/${conf_guest}/*.conf)" | |||
| all_configs="${all_configs} ${conf_configs}" | |||
|
|
|||
| local tmpfs_configs="$(ls ${common_path}/confidential_containers/tmpfs.conf)" | |||
zvonkok
reviewed
Jan 24, 2025
| @@ -0,0 +1 @@ | |||
| CONFIG_TMPFS_XATTR=y | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During pull inside the guest, overlayfs expects xattrs.
Fixes: guest-components#876
Kudos for @mythi and @Xynnn007 for suggesting the fix.