Set INSTALLER_UNATTENDED for user scripts
#885
Conversation
conda-bot
added
the
cla-signed
|
@mrclary - can you give this branch a try? You can check for |
examples/scripts/post_install.bat
Outdated
| @@ -3,6 +3,7 @@ if not "%INSTALLER_NAME%" == "Scripts" exit 1 | |||
| if not "%INSTALLER_VER%" == "X" exit 1 | |||
| if not "%INSTALLER_PLAT%" == "win-64" exit 1 | |||
| if not "%INSTALLER_TYPE%" == "EXE" exit 1 | |||
| if "%INSTALLER_UNATTENDED%" == "" exit 1 | |||
There was a problem hiding this comment.
Since the tests are run in batch/headless/silent mode, should we assert that the value be 1?
There was a problem hiding this comment.
Let's try :)
| if "%INSTALLER_UNATTENDED%" == "" exit 1 | |
| if not "%INSTALLER_UNATTENDED%" == "1" exit 1 |
There was a problem hiding this comment.
Let's expand this to the other bat file and the sh scripts ([[ "${INSTALLER_UNATTENDED}" == "1" ]] || exit 1 or something) and I think we have a good test here.
There was a problem hiding this comment.
Oops you are right, I forgot the other files. Added some additional tests.
There was a problem hiding this comment.
Seems to be passing.
Co-authored-by: Marco Esters <[email protected]>
Looks like that worked! |
|
Thanks @jaimergp @marcoesters 🚀 |
With conda/constructor#885, batch/silent mode installs will automatically set INSTALLER_UNATTENDED environment variable accessible by user scripts. Until the next constructor version (>3.9.3) users may set either CI=1 or INSTALLER_UNATTENDED=1 at the commandline.
With conda/constructor#885, batch/silent mode installs will automatically set INSTALLER_UNATTENDED environment variable accessible by user scripts. Until the next constructor version (>3.9.3) users may set either CI=1 or INSTALLER_UNATTENDED=1 at the commandline.
With conda/constructor#885, batch/silent mode installs will automatically set INSTALLER_UNATTENDED environment variable accessible by user scripts. Until the next constructor version (>3.9.3) users may set either CI=1 or INSTALLER_UNATTENDED=1 at the commandline.
Description
Closes #882
Checklist - did you ...
newsdirectory (using the template) for the next release's release notes?