Add tests for successful virtual_specs checks
#843
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
conda-bot
added
the
cla-signed
|
This is weird. This PR makes things at conda-forge/miniforge#626 pass, but it fails here. Previous iterations made things work here, but fail at the miniforge PR. 🤷 |
marcoesters
reviewed
Aug 15, 2024
| @@ -1139,7 +1139,7 @@ Section "Install" | |||
| System::Call 'kernel32::SetEnvironmentVariable(t,t)i("CONDA_SOLVER", "classic").r0' | |||
| SetDetailsPrint TextOnly | |||
| DetailPrint "Checking virtual specs..." | |||
| push '"$INSTDIR\_conda.exe" create --dry-run --prefix "$INSTDIR" --offline @VIRTUAL_SPECS@' | |||
| push '"$INSTDIR\_conda.exe" create --dry-run --prefix "$INSTDIR\envs\_virtual_specs_checks" --offline @VIRTUAL_SPECS@' | |||
There was a problem hiding this comment.
Do we need to create a temporary directory here, too?
There was a problem hiding this comment.
Micromamba is not used often on Windows due to the lack of menuinst, so it's not as critical. No clue how to create a tempdir via NSIS either.
There was a problem hiding this comment.
I think I know why we don't need to. We are setting CONDA_PKGS_DIRS here: https://github.com/conda/constructor/blob/main/constructor/nsis/main.nsi.tmpl#L1124
In the sh and pkg installers, that environment variable is set after the checks for virtual specs.
marcoesters
previously approved these changes
Aug 15, 2024
marcoesters
reviewed
Aug 15, 2024
marcoesters
approved these changes
Aug 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Comes from conda-forge/miniforge#626.
micromambadoesn't like something in that dry-run, apparently :)Checklist - did you ...
newsdirectory (using the template) for the next release's release notes?