Use separate job to create issues on test failure #782
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
conda-bot
added
the
cla-signed
jaimergp
reviewed
May 8, 2024
|
LGTM. Let's fix the conflicts and address the branch == main issue and that's all. |
jaimergp
reviewed
May 8, 2024
jaimergp
approved these changes
May 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Submitting issues on test failures in the test job can result in duplicate issues since the tests run in parallel. This introduces a race condition.
Instead, use a separate job that gets called when all tests have concluded.
Also, add a pre-commit hook to check GitHub workflows, which has been missing so far.
Checklist - did you ...
newsdirectory (using the template) for the next release's release notes?