From edbdbf132fb4491353919e7ff60272d3978af6a8 Mon Sep 17 00:00:00 2001
From: jaimergp <jaimergp@users.noreply.github.com>
Date: Sun, 17 Nov 2024 15:22:36 +0100
Subject: [PATCH] progress_notifications must be bool

---
 constructor/osx/prepare_installation.sh | 2 +-
 constructor/osx/run_installation.sh     | 2 +-
 constructor/osx/run_user_script.sh      | 2 +-
 constructor/osxpkg.py                   | 2 +-
 4 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/constructor/osx/prepare_installation.sh b/constructor/osx/prepare_installation.sh
index 0b63fc93b..dd5309ab9 100644
--- a/constructor/osx/prepare_installation.sh
+++ b/constructor/osx/prepare_installation.sh
@@ -8,7 +8,7 @@ set -euo pipefail
 
 notify() {
 # shellcheck disable=SC2050
-{%- if progress_notifications == "true" %}
+{%- if progress_notifications %}
 osascript <<EOF
 display notification "$1" with title "📦 Install {{ installer_name }} {{ installer_version }}"
 EOF
diff --git a/constructor/osx/run_installation.sh b/constructor/osx/run_installation.sh
index 8ca133ae5..708b04a1d 100644
--- a/constructor/osx/run_installation.sh
+++ b/constructor/osx/run_installation.sh
@@ -10,7 +10,7 @@ set -euo pipefail
 
 notify() {
 # shellcheck disable=SC2050
-{%- if progress_notifications == "true" %}
+{%- if progress_notifications %}
 osascript <<EOF
 display notification "$1" with title "📦 Install __NAME__ __VERSION__"
 EOF
diff --git a/constructor/osx/run_user_script.sh b/constructor/osx/run_user_script.sh
index 6de59c489..ae3516039 100644
--- a/constructor/osx/run_user_script.sh
+++ b/constructor/osx/run_user_script.sh
@@ -8,7 +8,7 @@ set -euo pipefail
 
 notify() {
 # shellcheck disable=SC2050
-{%- if progress_notifications == "true" %}
+{%- if progress_notifications %}
 osascript <<EOF
 display notification "$1" with title "📦 Install __NAME__ __VERSION__"
 EOF
diff --git a/constructor/osxpkg.py b/constructor/osxpkg.py
index d3e11dfa0..b3831ec7f 100644
--- a/constructor/osxpkg.py
+++ b/constructor/osxpkg.py
@@ -338,7 +338,7 @@ def move_script(src, dst, info, ensure_shebang=False, user_script_type=None):
     variables["channels"] = ','.join(get_final_channels(info))
     variables["write_condarc"] = '\n'.join(add_condarc(info))
     variables["path_exists_error_text"] = path_exists_error_text
-    variables["progress_notifications"] = str(info.get('progress_notifications', False))
+    variables["progress_notifications"] = info.get('progress_notifications', False)
     variables["pre_or_post"] = user_script_type or '__PRE_OR_POST__'
     variables["constructor_version"] = info['CONSTRUCTOR_VERSION']
     variables["shortcuts"] = shortcuts_flags(info)