Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add workflow to copy conda-forge releases to repo releases #98

Merged
merged 7 commits into from
Sep 19, 2024

Conversation

jaimergp
Copy link
Collaborator

Description

I was doing this manually but it's better if this is done in public CI for provenance and transparency.

Checklist - did you ...

  • Add a file to the news directory (using the template) for the next release's release notes?
  • Add / update necessary tests?
  • Add / update outdated documentation?

@conda-bot conda-bot added the cla-signed [bot] added once the contributor has signed the CLA label Sep 13, 2024
Copy link
Contributor

@marcoesters marcoesters left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, even though I personally prefer not to use cd. That way, there is no need to keep track from where commands are called. However, this is a style question, so not a blocker.

@jaimergp jaimergp marked this pull request as ready for review September 19, 2024 08:03
@jaimergp jaimergp requested a review from a team as a code owner September 19, 2024 08:03
@jaimergp jaimergp merged commit f3183f7 into conda:main Sep 19, 2024
8 checks passed
@jezdez
Copy link
Member

jezdez commented Dec 5, 2024

I was just pointed out that this is being done, which I find troubling given that conda-forge is a lot less secure compared to reviewed releases. Given conda-standalone's fundamental position in the conda stack, this change would have needed a security minded review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed [bot] added once the contributor has signed the CLA
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants