-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
requests
is an optional dependency but there's no try/except
guard
#88
Comments
I would be inclined to go in the other direction; requests does have a real dependency tree and it is unfortunate that we should require it for basic packing/unpacking of .conda packages. If we had a try/except for |
I wonder, given the relation between conda-package-handling and conda-package-streaming, if a merging of conda-package-streaming into conda-package-handling would be preferable. |
I see conda-package-streaming as providing a "new", composable API and conda-package-handling existing only for backwards compatibility and the cph CLI. -streaming also replaces libarchive from pre-2.0 conda-package-handling. I would not merge the projects. |
Checklist
What happened?
If a user tries to use the remote features from
conda_package_streaming.url
with a regularconda create -n cps conda-package-streaming
, they will run into anImportError
forrequests
because the dependency was removed from the recipe.I would ask to either:
conda-package-streaming-core
+conda-package-streaming
without and withrequests
, respectively.try / except ImportError
clause similar to howzstandard
is handled.Conda Info
Conda Config
Conda list
Additional Context
Seen in conda/conda-package-handling#254
The text was updated successfully, but these errors were encountered: