Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regex in info_order is confusing #180

Closed
wolfv opened this issue Dec 19, 2022 · 2 comments
Closed

Regex in info_order is confusing #180

wolfv opened this issue Dec 19, 2022 · 2 comments
Labels
locked [bot] locked due to inactivity stale::closed [bot] closed after being marked as stale stale [bot] marked as stale due to inactivity type::bug describes erroneous operation, use severity::* to classify the type

Comments

@wolfv
Copy link

wolfv commented Dec 19, 2022

The code contains a regex to modify the file extension for hashing / sorting:

_, ext = os.path.splitext(f)
# Strip any .dylib.* and .so.* and rename .dylib to .so
ext = re.sub(r'(\.dylib|\.so).*$', r'.so', ext)

It looks like the regex is supposed to do a great deal of things, but if I am not mistaken splitext will always cut off after the first dot from the right. So one could write just as well:

if ext == '.dylib':
     ext = '.so'
@wolfv wolfv added the type::bug describes erroneous operation, use severity::* to classify the type label Dec 19, 2022
Copy link

github-actions bot commented Jan 6, 2024

Hi there, thank you for your contribution!

This issue has been automatically marked as stale because it has not had recent activity. It will be closed automatically if no further activity occurs.

If you would like this issue to remain open please:

  1. Verify that you can still reproduce the issue at hand
  2. Comment that the issue is still reproducible and include:
    - What OS and version you reproduced the issue on
    - What steps you followed to reproduce the issue

NOTE: If this issue was closed prematurely, please leave a comment.

Thanks!

@github-actions github-actions bot added the stale [bot] marked as stale due to inactivity label Jan 6, 2024
@github-actions github-actions bot added the stale::closed [bot] closed after being marked as stale label Feb 5, 2024
@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Feb 5, 2024
@github-project-automation github-project-automation bot moved this to 🏁 Done in 🧭 Planning Feb 5, 2024
@wolfv
Copy link
Author

wolfv commented Feb 5, 2024

We're in the process of cleaning up most of the confusing code in rattler-build: https://github.com/prefix-dev/rattler-build/

@github-actions github-actions bot added the locked [bot] locked due to inactivity label Aug 27, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 27, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
locked [bot] locked due to inactivity stale::closed [bot] closed after being marked as stale stale [bot] marked as stale due to inactivity type::bug describes erroneous operation, use severity::* to classify the type
Projects
Archived in project
Development

No branches or pull requests

1 participant