fix: allow incomplete specs during intermediate parsing stages #5555
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
conda-bot
added
the
cla-signed
CodSpeed Performance ReportMerging #5555 will not alter performanceComparing Summary
|
beckermr
changed the title
jaimergp
reviewed
Nov 26, 2024
| pytest.fail("Undefined variable did NOT cause spec parsing error!") | ||
| else: | ||
| print("parsed OK!") | ||
| except (Exception, SystemExit): |
There was a problem hiding this comment.
Do we have a more concrete exception set?
There was a problem hiding this comment.
Not reliably no. I have already fixed a bug where when the exception handling in one part of the code changed, the test suite broke because a new kind of exception was raised in another part of the code. For now, any exception will work.
jaimergp
approved these changes
Nov 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR allows incomplete specs if they do not parse by skipping them for intermediate parsing stages. This behavior has been in the code for a while if a spec was completely specified by eg jinja2 (eg a list element
- {{ mpi }}). The PR extends this behavior to any soec that does not parse during intermediate stages. For the final parsing stage, specs that do not parse will raise.Checklist - did you ...
newsdirectory (using the template) for the next release's release notes?