Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: catch CondaBuildUserError w/ SystemExit #5538

Merged
merged 4 commits into from
Nov 15, 2024
Merged

Conversation

beckermr
Copy link
Contributor

@beckermr beckermr commented Nov 15, 2024

Description

This PR catches CondaBuildUserError with SystemExit in internal routines in the code. What is going on is that as we've slowly been moving sys.exit calls to raising a CondaBuildUserError, we've inadvertently started raising exceptions in places where we should not be.

Checklist - did you ...

  • Add a file to the news directory (using the template) for the next release's release notes?
  • Add / update necessary tests?
  • Add / update outdated documentation?

@conda-bot conda-bot added the cla-signed [bot] added once the contributor has signed the CLA label Nov 15, 2024
@beckermr beckermr changed the title fix: catch user errors in distribute_variants fix: catch CondaBuildUserError w/ SystemExit Nov 15, 2024
beckermr added a commit to conda-forge/staged-recipes that referenced this pull request Nov 15, 2024
Copy link

codspeed-hq bot commented Nov 15, 2024

CodSpeed Performance Report

Merging #5538 will not alter performance

Comparing beckermr-patch-1 (5bffa4d) with main (41856b5)

Summary

✅ 5 untouched benchmarks

@beckermr beckermr marked this pull request as ready for review November 15, 2024 16:50
@beckermr beckermr requested a review from a team as a code owner November 15, 2024 16:50
@beckermr
Copy link
Contributor Author

@conda/builds-tools this one is ready for review!

@beckermr beckermr enabled auto-merge (squash) November 15, 2024 18:48
@beckermr beckermr merged commit 0ad4bb6 into main Nov 15, 2024
28 checks passed
@beckermr beckermr deleted the beckermr-patch-1 branch November 15, 2024 18:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed [bot] added once the contributor has signed the CLA
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants