Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Warn about upcoming default change in conda_pkg_format #5534

Merged
merged 12 commits into from
Nov 13, 2024
Merged

Warn about upcoming default change in conda_pkg_format #5534

merged 12 commits into from
Nov 13, 2024

Conversation

jaimergp
Copy link
Contributor

@jaimergp jaimergp commented Nov 12, 2024 •
edited
Loading

Description

For more information, see #5527

Checklist - did you ...

  • Add a file to the news directory (using the template) for the next release's release notes?
  • Add / update necessary tests?
  • Add / update outdated documentation?

@conda-bot conda-bot added the cla-signed [bot] added once the contributor has signed the CLA label Nov 12, 2024
@jaimergp jaimergp force-pushed the warn-default-pkg-format branch from 5c9155d to 4c02af2 Compare November 12, 2024 09:30
@jaimergp jaimergp marked this pull request as ready for review November 12, 2024 09:31
@jaimergp jaimergp requested a review from a team as a code owner November 12, 2024 09:31
@jaimergp jaimergp mentioned this pull request Nov 12, 2024
Merged
3 tasks
@codspeed-hq CodSpeed HQ
Copy link

codspeed-hq bot commented Nov 12, 2024 •
edited
Loading

CodSpeed Performance Report

Merging #5534 will not alter performance

Comparing jaimergp:warn-default-pkg-format (00271b3) with main (4401820)

Summary

✅ 5 untouched benchmarks

@jezdez jezdez mentioned this pull request Nov 12, 2024
Merged
3 tasks
jezdez
jezdez requested changes Nov 12, 2024
View reviewed changes
Copy link
Member

@jezdez jezdez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For consistency purposes let's use the deprecations functionality since it's easier to filter for end users than loggers

conda_build/cli/main_build.py Outdated Show resolved Hide resolved
conda_build/cli/main_build.py Outdated Show resolved Hide resolved
@jakirkham jakirkham requested a review from jezdez November 12, 2024 19:26
@jaimergp
Copy link
Contributor Author

Yay, passing now! Ready for review @conda/builds-tools

@jaimergp jaimergp requested a review from a team November 13, 2024 14:39
@jezdez jezdez merged commit 0ae2f01 into conda:main Nov 13, 2024
28 checks passed
@beeankha beeankha mentioned this pull request Nov 15, 2024
Closed
45 tasks
@kenodegard kenodegard mentioned this pull request Nov 21, 2024
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dholth dholth dholth left review comments

@beeankha beeankha beeankha approved these changes

@jezdez jezdez jezdez approved these changes

Assignees
No one assigned
Labels
cla-signed [bot] added once the contributor has signed the CLA
Projects
🔎 Review
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@jaimergp @jezdez @dholth @beeankha @conda-bot