-
Notifications
You must be signed in to change notification settings - Fork 427
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove old full-index-in-memory loading and conda.plan
-related solver handling
#5154
Comments
I'll look into this during the next couple of weeks. |
xref #4961. Copied here: In #4431 I was investigating some differences in timings between My research led me to finding out that those extra minutes are spent creating the build index, which is the aggregation of all the source channels (e.g. defaults, conda-forge) and their platforms ( The slow part is not the repodata fetching, but creating the million+
It feels like we could do this better, as @dholth was saying #4431 (comment). The interface with the |
@zklaus, summarizing our conversation earlier today: To note:
Approaches:
|
It would also be a great idea to make PackageRecord instantiate more quickly. |
I'll create an issue for this if it doesn't exist already. Besides that, I think this is ready to close after #5488 and conda/conda#13880, right? |
Done: conda/conda#14426 |
In gh-5074 we removed the
conda.models.dist.Dist
usage fromconda-build
.This included copying over the
install_actions
/execute_actions
/display_actions
functions fromconda.plan
(which only continued to exist to serve these deprecated functions to
conda-build
).These functions, which are as of gh-5074 now part of
conda_build.environ
, are reduced to have only the code actually used inconda-build
.But their behavior still remained the same, i.e., they still use the same old solver invocations that loads the whole repodata index into memory, not benefiting from the reduced resource usage via conda/conda#12050 .
To be able to work with the reduced/only partially loaded index, we need to deprecate/remove some functionality that relies on iterating over the full index.
gh-5152 marks parts related to that as deprecated.
The major part to look out for when we'll replace the current
install_actions
code is that the index has to stay in a consistent state throughout a recipe build.Closes #4961
The text was updated successfully, but these errors were encountered: