Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing parenthesis in call to set.add #5063

Closed
dadrake3 opened this issue Nov 9, 2023 · 2 comments
Closed

Missing parenthesis in call to set.add #5063

dadrake3 opened this issue Nov 9, 2023 · 2 comments
Labels
source::community catch-all for issues filed by community members stale::closed [bot] closed after being marked as stale stale [bot] marked as stale due to inactivity type::bug describes erroneous operation, use severity::* to classify the type

Comments

@dadrake3
Copy link

dadrake3 commented Nov 9, 2023

https://github.com/conda/conda-build/blame/c71c4abee1c85f5a36733c461f224941ab3ebbd1/conda_build/skeletons/cpan.py#L870-L873

This line errors with set.add() takes exactly one argument (2 given), I believe it should be wrapping the args as a tuple. Should be pretty simple fix. Guessing its not covered by unit test.

I can create a PR if thats cool.

@kenodegard
Copy link
Contributor

@dadrake3 Yup missing parenthesis.

And if possible, adding a test would also be swell since you have a use case on hand!

@travishathaway travishathaway added type::bug describes erroneous operation, use severity::* to classify the type source::community catch-all for issues filed by community members labels Dec 12, 2023
Copy link

Hi there, thank you for your contribution!

This issue has been automatically marked as stale because it has not had recent activity. It will be closed automatically if no further activity occurs.

If you would like this issue to remain open please:

  1. Verify that you can still reproduce the issue at hand
  2. Comment that the issue is still reproducible and include:
    - What OS and version you reproduced the issue on
    - What steps you followed to reproduce the issue

NOTE: If this issue was closed prematurely, please leave a comment.

Thanks!

@github-actions github-actions bot added the stale [bot] marked as stale due to inactivity label Dec 12, 2024
@github-actions github-actions bot added the stale::closed [bot] closed after being marked as stale label Jan 12, 2025
@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Jan 12, 2025
@github-project-automation github-project-automation bot moved this from 🆕 New to 🏁 Done in 🧭 Planning Jan 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
source::community catch-all for issues filed by community members stale::closed [bot] closed after being marked as stale stale [bot] marked as stale due to inactivity type::bug describes erroneous operation, use severity::* to classify the type
Projects
Status: 🏁 Done
Development

No branches or pull requests

3 participants