Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow non-first-child table cells to wrap #5056

Merged
merged 1 commit into from
Nov 3, 2023
Merged

Allow non-first-child table cells to wrap #5056

merged 1 commit into from
Nov 3, 2023

Conversation

kenodegard
Copy link
Contributor

@kenodegard kenodegard commented Nov 2, 2023 •
edited
Loading

Description

Resolves #3713

Before
Screenshot 2023-11-02 at 4 19 09 PM

After
Screenshot 2023-11-02 at 4 19 19 PM

Checklist - did you ...

  • Add a file to the news directory (using the template) for the next release's release notes?
  • Add / update necessary tests?
  • Add / update outdated documentation?

@kenodegard kenodegard self-assigned this Nov 2, 2023
@kenodegard
Copy link
Contributor Author

kenodegard commented Nov 2, 2023 •
edited
Loading

@travishathaway is this something the new theme will handle better?

@conda-bot conda-bot added the cla-signed [bot] added once the contributor has signed the CLA label Nov 2, 2023
kathatherine
kathatherine approved these changes Nov 2, 2023
View reviewed changes
Copy link
Contributor

@kathatherine kathatherine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's much better!

As far as I can tell, tables are still pretty basic in the base pydata-sphinx-theme.

beeankha
beeankha approved these changes Nov 3, 2023
View reviewed changes
Copy link
Member

@beeankha beeankha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✨

@kenodegard kenodegard merged commit 923b59a into conda:main Nov 3, 2023
11 checks passed
@kenodegard kenodegard deleted the wrap-tables branch November 3, 2023 15:29
@github-actions github-actions bot added the locked [bot] locked due to inactivity label Nov 3, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 3, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@kathatherine kathatherine kathatherine approved these changes

@beeankha beeankha beeankha approved these changes

Assignees

@kenodegard kenodegard

Labels
cla-signed [bot] added once the contributor has signed the CLA locked [bot] locked due to inactivity
Projects
🔎 Review
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Improve legibility of larger tables
4 participants
@kenodegard @beeankha @kathatherine @conda-bot