Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

conda-build doesn't check if a mismatch between the version in the wheel filename and the version of the conda package #5016

Open
2 tasks done
skupr-anaconda opened this issue Sep 27, 2023 · 4 comments
Labels
source::anaconda created by members of Anaconda, Inc. type::bug describes erroneous operation, use severity::* to classify the type

Comments

@skupr-anaconda
Copy link
Contributor

Checklist

  • I added a descriptive title
  • I searched open reports and couldn't find a duplicate

What happened?

conda-build doesn't raise an error if the version of the package is 0.0.0 (the use case: a missing setuptools_scm in the host).

From build logs, see here:

 Source in /private$SRC_DIR has version 0.0.0, which satisfies requirement SQLAlchemy-JSONField==0.0.0 from file:///private$SRC_DIR

but the version must be sqlalchemy-jsonfield 1.0.1.post0.

The problem is not with 0.0.0, but with a mismatch between the version in the wheel filename and the version of the conda package.

I tried to rebuild airflow (it relies on sqlalchemy-jsonfield) and in the test step pip check says you have an incorrect version of the dependency.

If there is one thing we could change, it would be to add a check in conda-build to make sure that the version of the package produced when running pip install . matches the version of the feedstock recipe.

P.S. The issue partially related to #316 but not fully.

Conda Info

No response

Conda Config

No response

Conda list

No response

Additional Context

No response

@skupr-anaconda skupr-anaconda added the type::bug describes erroneous operation, use severity::* to classify the type label Sep 27, 2023
@github-project-automation github-project-automation bot moved this to 🆕 New in 🧭 Planning Sep 27, 2023
@skupr-anaconda skupr-anaconda changed the title conda-build doesn't check if the version of the package is 0.0.0 conda-build doesn't check if a mismatch between the version in the wheel filename and the version of the conda package Sep 27, 2023
@travishathaway travishathaway added the source::anaconda created by members of Anaconda, Inc. label Nov 6, 2023
@ifitchet
Copy link

bump

@lorepirri
Copy link

bump!

@beeankha
Copy link
Member

beeankha commented Oct 2, 2024

After discussing with @kenodegard , we came to the agreement that this feature request, while useful and valid, seems to fall more into the "lint check" category vs a hard-coded expectation that all packages must meet. This could be a great opportunity to revisit conda-verify and to either revive that project as it's written or rework it as a conda plugin that can provide customized post-build checks.

@ifitchet
Copy link

ifitchet commented Oct 3, 2024

So we are going to leave this issue open as "encouragement" for those other opportunities?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
source::anaconda created by members of Anaconda, Inc. type::bug describes erroneous operation, use severity::* to classify the type
Projects
Status: 🆕 New
Development

No branches or pull requests

5 participants