Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update pip install documentation in recipes for dependencies and build isolation #4924

Closed
2 tasks done
riccardoporreca opened this issue Jul 3, 2023 · 3 comments
Closed
2 tasks done
Labels
stale::closed [bot] closed after being marked as stale stale [bot] marked as stale due to inactivity type::feature request for a new feature or capability

Comments

@riccardoporreca
Copy link

riccardoporreca commented Jul 3, 2023

Checklist

  • I added a descriptive title
  • I searched open requests and couldn't find a duplicate

What is the idea?

We find many recipes around that use pip install --no-deps . -vv in build scripts, which is also documented in many places for conda-build.

However, pip dependencies, as well as build isolation, are completely disabled via environment variables by conda-build itself, see https://github.com/conda/conda-build/blob/3.25.0/conda_build/build.py#L3163-L3183

Why is this needed?

To make users of conda-build and maintainers of conda recipes aware of the pip configuration done by conda-build under the hood and suggest a simple pip install . -vv in build scripts

What should happen?

Documentation and examples updated

See https://github.com/search?q=repo%3Aconda%2Fconda-build+%22pip+install%22+%22--no-deps%22&type=code

Additional Context

No response

@riccardoporreca riccardoporreca added the type::feature request for a new feature or capability label Jul 3, 2023
@github-project-automation github-project-automation bot moved this to 🆕 New in 🧭 Planning Jul 3, 2023
@riccardoporreca
Copy link
Author

Happy to help out and draft a PR

@riccardoporreca
Copy link
Author

@kenodegard, I stumbled over #4960, which seems to go in quite the opposite direction compared to what I was bringing up here...

Copy link

github-actions bot commented Nov 9, 2024

Hi there, thank you for your contribution!

This issue has been automatically marked as stale because it has not had recent activity. It will be closed automatically if no further activity occurs.

If you would like this issue to remain open please:

  1. Verify that you can still reproduce the issue at hand
  2. Comment that the issue is still reproducible and include:
    - What OS and version you reproduced the issue on
    - What steps you followed to reproduce the issue

NOTE: If this issue was closed prematurely, please leave a comment.

Thanks!

@github-actions github-actions bot added the stale [bot] marked as stale due to inactivity label Nov 9, 2024
@github-actions github-actions bot added the stale::closed [bot] closed after being marked as stale label Dec 9, 2024
@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Dec 9, 2024
@github-project-automation github-project-automation bot moved this from 🆕 New to 🏁 Done in 🧭 Planning Dec 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stale::closed [bot] closed after being marked as stale stale [bot] marked as stale due to inactivity type::feature request for a new feature or capability
Projects
Status: 🏁 Done
Development

No branches or pull requests

1 participant