-
Notifications
You must be signed in to change notification settings - Fork 427
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add menuinst JSON file validation #4405
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anaconda-issue-bot
added
the
cla-signed
[bot] added once the contributor has signed the CLA
label
Mar 24, 2022
jaimergp
force-pushed
the
menuinst-validation
branch
from
March 29, 2022 10:43
9bb0652
to
33a607a
Compare
beeankha
added
the
source::partner
created by or for an Anaconda, Inc. partner company
label
Dec 7, 2022
19 tasks
Turns out |
jezdez
previously approved these changes
Nov 7, 2023
Errors unrelated to this PR (to be fixed by #5059). |
travishathaway
approved these changes
Nov 22, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
cla-signed
[bot] added once the contributor has signed the CLA
locked
[bot] locked due to inactivity
source::partner
created by or for an Anaconda, Inc. partner company
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the logic to validate the new menuinst JSONs at build-time. It will only print a warning for now. If an error should be raised, we need to add a logic similar to the overlinking analysis, but I don't know if that's what people want... For now I kept it simple. Let me know!