Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add menuinst JSON file validation #4405

Merged
merged 46 commits into from
Nov 25, 2023
Merged

Conversation

jaimergp
Copy link
Contributor

@jaimergp jaimergp commented Mar 24, 2022

This adds the logic to validate the new menuinst JSONs at build-time. It will only print a warning for now. If an error should be raised, we need to add a logic similar to the overlinking analysis, but I don't know if that's what people want... For now I kept it simple. Let me know!

@anaconda-issue-bot anaconda-issue-bot added the cla-signed [bot] added once the contributor has signed the CLA label Mar 24, 2022
@jaimergp jaimergp closed this Mar 29, 2022
@jaimergp jaimergp reopened this Mar 29, 2022
@jaimergp jaimergp marked this pull request as ready for review March 29, 2022 12:25
@beeankha beeankha added the source::partner created by or for an Anaconda, Inc. partner company label Dec 7, 2022
@jaimergp jaimergp requested a review from jezdez November 7, 2023 09:31
@jaimergp
Copy link
Contributor Author

jaimergp commented Nov 7, 2023

Turns out utils.get_logger() injects a deduplication filter by default, so the 2nd test would never raise a warning because the message (albeit with different args!) had already been 'seen'. 🤷 dedupe=False is enough to make it work.

jezdez
jezdez previously approved these changes Nov 7, 2023
@jaimergp
Copy link
Contributor Author

Errors unrelated to this PR (to be fixed by #5059).

@travishathaway travishathaway self-requested a review November 22, 2023 09:46
conda_build/post.py Outdated Show resolved Hide resolved
@jaimergp jaimergp merged commit f77849b into conda:main Nov 25, 2023
24 checks passed
@kenodegard kenodegard mentioned this pull request Dec 1, 2023
67 tasks
@github-actions github-actions bot added the locked [bot] locked due to inactivity label Nov 25, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla-signed [bot] added once the contributor has signed the CLA locked [bot] locked due to inactivity source::partner created by or for an Anaconda, Inc. partner company
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

5 participants