Missing spyder_light.ico icon in Windows' menuitem (reset Spyder settings)

[bkreider]

Solution to issue cannot be found in the documentation.

• I checked the documentation.

Issue

The menuitem for "Reset Spyder Settings" is missing on windows, because the icon is never included in the bld.bat.

I would update the bld.bat with this:

copy %SRC_DIR%\img_src\spyder_reset.ico %MENU_DIR%\

And the menu_windows.json: https://github.com/conda-forge/spyder-feedstock/blob/main/recipe/menu-windows.json#L15

{
    "menu_name": "${DISTRIBUTION_NAME}",
    "menu_items":
    [
        {
            "name": "Spyder",
            "pywscript": "${PYTHON_SCRIPTS}/spyder-script.py",
            "workdir": "${PERSONALDIR}/Python Scripts",
            "icon": "${PYTHON_SCRIPTS}/spyder.ico"
        },
        {
            "name": "Reset Spyder Settings",
            "pyscript": "${PYTHON_SCRIPTS}/spyder-script.py --reset",
            "workdir": "${USERPROFILE}",
            "icon": "${PYTHON_SCRIPTS}/spyder_light.ico" <<<<<<<<<<<<<<<<<<<
        }
    ]
}

Change this to spyder_reset.ico which is what the file was renamed to.

Cheers.

Installed packages

n/a

Environment info

n/a

[dalthviz]

Hi @bkreider thank you for the feedback! Indeed seems like a bug! The proposed solution makes sense to me 👍 but just in case, what do you think @ccordoba12 ?

[ccordoba12]

Yep, I agree that we need to replace that icon name. Thanks for bringing this up to our attention @bkreider!

However, spyder_reset.ico is using our old icon and not the new one. Since we don't have a new special icon for resetting (we'll see if we can come up with one in the coming months), for now let's use spyder.ico for that menu entry too.

@dalthviz, please do that change in PR #147.