-
-
Notifications
You must be signed in to change notification settings - Fork 342
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release 23.10 #511
Comments
we used to have troubles with boa compatibility. if the tests pass. I'm ok with a new release |
Yes this is a good point Raised this item at a previous core meeting, the feedback we got there was to switch to using So maybe this provides a way forward? |
i'm ok with removing the |
The plan me and @jaimergp talked about is to first release conda-smithy which will switch to conda-build+conda-libmamba-solver by default, wait to see if there are any issues and if there are no issues, release a new mambaforge. |
The other solution was to wait for a new boa release. See mamba-org/boa#381 |
great sounds awesome! |
Thanks Isuru! 🙏 This helps answer the question of what the steps would be
If we want to do more testing first, that sounds reasonable
If we think there will be movement there, great! That said, it looks like that issue has been open for a week without response Also this was brought up at the core meeting a few weeks ago ( after months of being in a holding pattern around various incompatibilities: conda-forge/boa-feedstock#73 ) To be clear this is not intended as criticism towards anyone. There have been lots of changes in tooling and it takes work to keep things in a compatible state That said, think taking a practical approach to resolving this (like moving forward here and letting |
Yep! Anything holding back a conda-smithy release this week? |
Updating the thread, |
I just really don't understand the constraints of boa. it says it can support newer mamba, but then the Miniforge builder complains |
@hmaarrfk, the latest builds were marked broken due to an issue with building recipes on conda-forge. |
Yep the PR that made that change has a comment at the end that provides more context: conda-forge/boa-feedstock#74 (comment) Agree the situation around That said, as the newest This approach was tested in |
cc @jezdez (for awareness) |
The problem right now is that the latest conda-build is not compatible with boa. And if we update the Miniforge distro here with the latest stuff, That's not a problem if we switch to conda-build + conda-libmamba-solver. IN fact, we have done so I think? But some feedstocks are incompatible due to a bug I'm chasing in conda/conda-libmamba-solver#386. These feedstocks need So I see three solutions:
conda_build_tool: mambabuild
conda_install_tool: mamba
miniforge_version: 23.3.1-0 # this key doesn't exist yet Thoughts? |
I feel like we should choose this. though it is unclear to me exactly what bugs exist. they can't be irreconcilable.... |
Thanks for summarizing the situation Jaime! 🙏 That is also my understanding. Hope that helps for other folks running into this issue without context While in principle I understand why folks would want In a prior core meeting, we discussed options and decided to drop the The next step we decided was to start using We have been doing that for a little bit. We found a few bugs (expected given we went from testing in staged-recipes to testing in all of conda-forge). The A new Miniforge would use the new solver by default. So think we want to be confident that is working as expected. See the current bug as just part of that effort we had committed to Think once we are comfortable with the To summarize: If 1 happens, great! Just don't think we should block on that any more If we need to go faster for some reason, would also be ok with 2, but would need to be convinced as to why we need to go faster (since this will also result in an uptick in Miniforge user issues) Would much prefer 3. It is consistent with what we have done so far and should minimize disruption (while letting us to continue to make progress) |
Presumably that release was 0.16? In any case, both before and after conda-forge/boa-feedstock#77, the boa recipe did not specify a cap on the conda-build version. |
Reopenning since #518 was merged in haste and will likely be reverted (or at the very least, not marked as the latest release) |
Now that Conda 23.10 is released and the blogpost is up. Congratulations to the team for making that happen 👏
What would be our next steps for packaging it in Miniforge?
The text was updated successfully, but these errors were encountered: