Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix naming in .pc files on Windows of ssl and crypto library #42

Closed
traversaro opened this issue Sep 11, 2023 · 1 comment · Fixed by #43
Closed

Fix naming in .pc files on Windows of ssl and crypto library #42

traversaro opened this issue Sep 11, 2023 · 1 comment · Fixed by #43

Comments

@traversaro
Copy link
Contributor

See #40 (comment) and following comments.
@traversaro traversaro mentioned this issue Sep 11, 2023
Merged
@traversaro
Copy link
Contributor Author

traversaro commented Sep 11, 2023 •
edited
Loading

The .pc file is:

Name: libzip
Description: library for handling zip archives
Version: 1.10.1
Libs:  -L${libdir} -lzip
Libs.private:  -ladvapi32 -lbzip2 -lssl -lcrypto -lz
Cflags: -I${includedir}

as we only ship shared libraries, we can just remove Libs.private as we should not be using it, and we are using it only due to conda-forge/conda-forge.github.io#1880 .

@traversaro traversaro mentioned this issue Sep 11, 2023
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove Libs.private from .pc file traversaro/libzip-feedstock
1 participant
@traversaro