Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove dependency on jms/translation-bundle #125

Open
thelem opened this issue May 10, 2020 · 0 comments
Open

Remove dependency on jms/translation-bundle #125

thelem opened this issue May 10, 2020 · 0 comments

Comments

@thelem
Copy link
Contributor

thelem commented May 10, 2020

The only occurrences of the string "JMS" that I can find anywhere in the module are:

  • In the changelog and readme
  • In composer.json
  • In tool-id/tool-name attributes in the translation files. These seem to be effectively comments.
  • In random strings in package-lock.json and *.map files (unrelated to JMS Translation bundle)

Based on #10 I think this package was added as a dependency by mistake, and we've been maintaining it ever since.

We do use the Symfony translation service, so we should add a direct dependency on that.

Pull request coming soon.

thelem added a commit to thelem/ComurImageBundle that referenced this issue May 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant