Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] Database Backup #33

Open
CrageJ opened this issue Aug 10, 2024 · 4 comments
Open

[Feature Request] Database Backup #33

CrageJ opened this issue Aug 10, 2024 · 4 comments
Labels
enhancement New feature or request priority:normal Normal priority; should be worked on when possible

Comments

@CrageJ
Copy link
Contributor

CrageJ commented Aug 10, 2024

Overview

Database may need reverting to an earlier version if there are user or operational errors. Creating a backup of recent versions of the database would be helpful in such a situation.

Details

Create a separate folder like db_backups to store a snapshot of all databases each day, for up to 72 hours,

Why would this feature be useful?

Catastrophic errors or misuse may render certain functionalities useless until they are fixed. having a copy before things "went bad" seems like the responsible thing to do.

Additional Notes

No response

@phoenixpereira phoenixpereira added the enhancement New feature or request label Aug 10, 2024
@phoenixpereira phoenixpereira moved this to Todo in DuckBot Aug 10, 2024
@phoenixpereira
Copy link
Member

Also pushing a change to production seems to delete the database.

@phoenixpereira phoenixpereira added the priority:normal Normal priority; should be worked on when possible label Aug 10, 2024
@CrageJ
Copy link
Contributor Author

CrageJ commented Aug 10, 2024

@phoenixpereira Can you find a way to keep persistent storage between sessions/merges? If everything gets overwritten whenever there's a merge then it's an issue that has to be addressed with the deployment environment.

Maybe look at EBS or S3?

I will see about implementing an on_shutdown() process as well

@phoenixpereira
Copy link
Member

phoenixpereira commented Aug 16, 2024

@phoenixpereira Can you find a way to keep persistent storage between sessions/merges? If everything gets overwritten whenever there's a merge then it's an issue that has to be addressed with the deployment environment.

Maybe look at EBS or S3?

I will see about implementing an on_shutdown() process as well

Fixed in #39/#40.

@rayokamoto
Copy link
Contributor

We might set up a cron job to backup the database to S3 as well, and if that's done this issue can be closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request priority:normal Normal priority; should be worked on when possible
Projects
Status: Todo
Development

No branches or pull requests

3 participants