Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue 1031 joinOuterMerge #1419

Draft
wants to merge 2 commits into
base: issue_1031_joinLeftMerge
Choose a base branch
from
Draft

Issue 1031 joinOuterMerge #1419

wants to merge 2 commits into from

Conversation

rnjtranjan
Copy link
Collaborator

No description provided.

adithyaov
adithyaov reviewed Jan 10, 2022
View reviewed changes
Copy link
Member

@adithyaov adithyaov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it possible to use a custom data type in the state and document it. It would be much easier to understand/review.

src/Streamly/Internal/Data/Stream/IsStream/Top.hs
Comment on lines +480 to +483
joinOuterMerge eq s1 =
IsStream.fromStreamD
. StreamD.joinOuterMerge eq (IsStream.toStreamD s1)
. IsStream.toStreamD
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of a point free notation, having s2 here seems more eloquent.

src/Streamly/Internal/Data/Stream/StreamD/Nesting.hs
Comment on lines +4034 to +4035

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
{-# INLINE_LATE step #-}
{-# INLINE_LATE step #-}

src/Streamly/Internal/Data/Stream/StreamD/Nesting.hs Outdated Show resolved Hide resolved
src/Streamly/Internal/Data/Stream/StreamD/Nesting.hs Show resolved Hide resolved
@rnjtranjan rnjtranjan requested a review from adithyaov January 12, 2022 12:04
@harendra-kumar harendra-kumar marked this pull request as draft July 5, 2023 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@harendra-kumar harendra-kumar Awaiting requested review from harendra-kumar

@adithyaov adithyaov Awaiting requested review from adithyaov

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rnjtranjan @adithyaov