Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate/remove the pipeChars/pipeBytes APIs #87

Open
harendra-kumar opened this issue Oct 5, 2024 · 0 comments
Open

Deprecate/remove the pipeChars/pipeBytes APIs #87

harendra-kumar opened this issue Oct 5, 2024 · 0 comments

Comments

@harendra-kumar
Copy link
Member

These APIs use implicit chunking using defaultChunkSize and currently there is no way to control the buffer size. We can supply the buffer size as a configuration option, but it is easier to use explicit chunking using stream APIs instead, that gives better control. For example, we can also use timedChunksOf API to flush the buffer after a timeout. If we incorporate all such possibilities into the configuration, that complicates the API. So use streaming directly instead.

pipeChars also has the encoding issue, we assume UTF-8 encoding. If we use streaming APIs directly then we have the option to use any encoding or decide it based on the environment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant