Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add integration test for Bijectors #348

Closed
yebai opened this issue Nov 5, 2024 · 3 comments · Fixed by #353
Closed

Add integration test for Bijectors #348

yebai opened this issue Nov 5, 2024 · 3 comments · Fixed by #353
Labels
enhancement (testing) Would improve the tests

Comments

@yebai
Copy link
Contributor

yebai commented Nov 5, 2024

We should perform similar tests in EnzymeAD/Enzyme.jl#2037 for Mooncake.

@mhauru, can you copy the tests over?
@yebai yebai added the enhancement (testing) Would improve the tests label Nov 5, 2024
@mhauru
Copy link
Contributor

mhauru commented Nov 5, 2024

Yes, will do.

@willtebbutt
Copy link
Member

Thanks Markus -- extra integration tests are always welcome!

@willtebbutt
Copy link
Member

On this -- if you find failing tests, please don't worry about fixing them. We can just find a good way to mark them as failing, and open an issue which says "fix failing Bijectors.jl integration tests"

@mhauru mhauru mentioned this issue Nov 7, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement (testing) Would improve the tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add Bijectors integration tests mhauru/Mooncake.jl
3 participants
@yebai @willtebbutt @mhauru