Use Ref to IRCode #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@yebai could you please take a quick look at this and let me know what you think? I'm not going to make a breaking release without at least having one other person taking a look at this. |
|
Alternatively, @oxinabox if you're free, could you take a look? |
oxinabox
approved these changes
Oct 21, 2024
oxinabox
reviewed
Oct 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This resolves a performance problem that Mooncake has with some Turing.jl models, without changing the functionality of this package. However, the interface changes very slightly, so this change is technically breaking.
edit: in short, if you construct very many
MistyClosureswhich contain quite quick functions (e.g. 20ns running time) and shove them in aVector, and then call them in sequence, having them take up 48B rather than 176B can actually make quite a substantial difference to performance.