Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request]: Support Resource Dir through CppInterOp #417

Open
anutosh491 opened this issue Jan 6, 2025 · 2 comments
Open

[Feature Request]: Support Resource Dir through CppInterOp #417

anutosh491 opened this issue Jan 6, 2025 · 2 comments
Labels
enhancement New feature or request

Comments

@anutosh491
Copy link
Collaborator

Description of new feature

Two main reasons why this would be helpful is that

  1. Xeus-cpp's non-wasm based kernels can make use of it through kernel.json
  "argv": [
      "/Users/anutosh491/micromamba/envs/xeus-cpp/bin/xcpp",
      "-f",
      "{connection_file}",
      "-resource-dir", "/Users/anutosh491/micromamba/envs/xeus-cpp/lib/clang/19",
      "-I", "/Users/anutosh491/micromamba/envs/xeus-cpp/include",
      "-std=c++20"
  ]

Currently we do provide a location "/Users/anutosh491/micromamba/envs/xeus-cpp/lib/clang/19" but this is just a placeholder right now and such a location doesn't exist during the setup.

  1. Xeus-cpp's wasm based kernel can make use of it through emscripten's preloading feature (--preload-file or --embed-file

Once we have a resource dir through cppinterop, we just move these files to dedicated location that also has contains emscripten's sysroot and then we preload all of these files together.

@anutosh491 anutosh491 added the enhancement New feature or request label Jan 6, 2025
@anutosh491
Copy link
Collaborator Author

IIRC some discussion was done on discord for the same but not sure we had a concrete way forward. Opening an issue to keep track of the same.
Maybe someone could educate me with what needs to be done if we have a solution.

@mcbarton
Copy link
Collaborator

mcbarton commented Jan 9, 2025

@anutosh491 @vgvassilev If we build the resource directory as part of the build process then we can mount it the virtual file system of the Jupyter lite build. When mounting we can pick the exact location of the resource dir. Its one of the options of the Jupyter lite build, so would be simple to implement.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants