Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No exception raised when using send_and_wait and custom instruction #23

Open
mattiskoh opened this issue Feb 10, 2023 · 2 comments
Open
Assignees

Comments

@mattiskoh
Copy link

When using a custom instruction based on the RRC custom_instruction template, that sends feedback i.e. parse_feedback, the custom instruction can get stuck and hang forever.

The culprit is the incorrect parsing of the feedback values, that normally would raise a Python Exception. However in conjunction with rrc's send_and_wait no Exception is raised whatsoever.

Expected Result

Python Exception raised

Actual Result

Nothing, script gets stuck.

Reproduction Steps

Parse a feedback incorrectly e.g. string_values[0] when string_values is an empty list

System Information

Operating System name and version, Python version, etc.
compas_rrc v 1.1.0

@gonzalocasas
Copy link
Contributor

@fleischp let's test this on Friday, I believe this is already fixed in the webservices branch.

@gonzalocasas
Copy link
Contributor

Fixed in the commit above, will be released in the next version!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants