Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Causes of small numerical inaccuracies that probably make sensitivity analysis noisy. #3

Open
rwest opened this issue May 18, 2022 · 0 comments

Comments

@rwest
Copy link
Member

rwest commented May 18, 2022

This particular repo may be water under the bridge, but @12Chao should take note.

See this section

        gas_out.append(1000 * 60 * kmole_flow_rate * gas.X.copy())  # molar flow rate in moles/minute
        surf_out.append(surf.X.copy())

surf_out.append(surf.X.copy())

then see
https://groups.google.com/g/cantera-users/c/uf6Trn08WIY/m/V42jpQouHgAJ
where it is explained that rsurf.kinetics.X is not surf.X, and r.thermo.X is not gas.X.

Also, "advance to steady state" probably has poor tolerance and accuracy, and isn't a good algorithm anyway. It probably works, ish, but if you're trying to do finite difference (for brute force sensitivity, for example) you need a repeatable thing. Perhaps should integrate to a specific multiple of the residence time, for example, something much more repeatable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant