Update to Python 3.12 #32548
Update to Python 3.12 #32548
Conversation
|
Thanks for contributing to openpilot! In order for us to review your PR as quickly as possible, check the following:
|
|
error is just due to missing assets, fixing right now |
|
metadrive is now failing in CI?
|
|
I'll look into fixing the metadrive error, but this PR will be blocked until the work is done that gets |
pyproject.toml
Outdated
| @@ -140,14 +140,14 @@ inputs = "*" | |||
| Jinja2 = "*" | |||
| lru-dict = "*" | |||
| matplotlib = "*" | |||
| metadrive-simulator = { version = "0.4.2.3", markers = "platform_machine != 'aarch64'" } # no linux/aarch64 wheels for certain dependencies | |||
| metadrive-simulator-py3-12 = { version = "0.3.0", markers = "platform_machine != 'aarch64'" } # no linux/aarch64 wheels for certain dependencies | |||
There was a problem hiding this comment.
I pushed your branch to our fork. can you install from git? https://github.com/commaai/metadrive/tree/python3.12
There was a problem hiding this comment.
you'll want to update that branch, 0.2.0 had missing assets. 0.3.0 adds them
There was a problem hiding this comment.
PR now uses the git that you linked. I should mention that the repo as it stands does rely on a release to exist in order to download assets for metadrive use (assuming they're not there locally)
It'll work fine since it will download the assets from the release coming from my repo: https://github.com/BBBmau/metadrive/releases/tag/0.3.0 but i figured I'd bring this up. Not sure if you want to leave as is, this is technically a temporary fix until they support it on theirs.
|
Looks like MetaDrive is prepared to merge our PR. Let's wait for that before continuing this metadriverse/metadrive#720 (comment) |
@adeebshihadeh Sounds good, i made the changes to the metadrive PR though it looks to be blocked by other dependencies that have still not yet supported 3.12 also. They are actively working on it which is good to see. |
Co-authored-by: Adeeb Shihadeh <[email protected]>
* 3.12 * pprofile is broken * use modified metadrivepy3-12 * 0.3.0 metadrive * add metadrive/commaai git dependency * metadrive git set * pin sounddevice 0.4.6 * datetime.utcnow() deprecation * poetry lock * make datetime not aware * poetry lock * pin pytools * google_crc32c wheel * unpin sounddevice * clean metadrive * use python crc * mypy * 3.12.4 * allow python3.11 * test * no pip * poetry * better * better * merge * remove * try * test * try this * snok * python * simpler * setuptools * lower * try * try * work? * ubuntu deps * ubuntu * try * remove * move * remove this * names * Update .github/workflows/tools_tests.yaml Co-authored-by: Adeeb Shihadeh <[email protected]> * python<4 * <3.13 --------- Co-authored-by: Adeeb Shihadeh <[email protected]> Co-authored-by: Maxime Desroches <[email protected]> old-commit-hash: 148eaf8
Fixes #32516
Second PR was created due to the revert of
Removing PyenvSame as the first PR, it uses a custom pypackage that uses metadrive with py3.12 support in order to get this merged now. Once the official metadrive repo updates and publishes a new release that supports 3.12 we can update it to use that one instead of this custom one.
https://pypi.org/project/metadrive-simulator-py3-12/