Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rework theming to use more defaults #3

Open
CrazyStevenz opened this issue May 9, 2020 · 1 comment
Open

Rework theming to use more defaults #3

CrazyStevenz opened this issue May 9, 2020 · 1 comment
Assignees
Labels
rework A redesign or rethink is needed web Related to the website

Comments

@CrazyStevenz
Copy link
Member

Right now, a lot of dark theme color settings are set inside the components themselves, ovewriting defaults. This happens due to two mistakes made during the original theming process:

  1. The navbar uses the primary.dark color instead of a dedicated accent color

  2. The primary colors for dark theme are the accent colors instead of white

@CrazyStevenz CrazyStevenz self-assigned this May 9, 2020
@CrazyStevenz
Copy link
Member Author

Material UI v5 is reworking theming so we're going to wait for them to complete it before making any changes.

@CrazyStevenz CrazyStevenz transferred this issue from college-resources/web Jun 30, 2021
@CrazyStevenz CrazyStevenz added rework A redesign or rethink is needed web Related to the website labels Jun 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
rework A redesign or rethink is needed web Related to the website
Projects
None yet
Development

No branches or pull requests

1 participant