-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Oversample should be removed #22
Comments
Hmm good catch - I wasn't sure if other versions (ps3000 etc) would expect it. But sounds like it was just a software API feature that was added then removed... |
My guess is that the previous oversample sample feature was done in real time and they figured that they didn't want to support that future versions of picoscopes. |
I took a look through the other devices to get an idea what's best across the board. It looks like ps2000/ps3000 have two versions of the API as well, with the 'A' version being similar to what we have in the PS6000, and also not using the 'oversample' parameter. The 'original' API versions do have the oversample feature. According to the docs things aren't completely backwards compatible... a few scopes don't work with the 'A' api. The ps4000 has a similar API to the PS6000, but does use the oversample parameter. Moving forward probably best to drop it then from our 'general' calls. Eventually should have a high-level call for setting up the oversampling, and the _lowLevel call deals with inserting it in the specific function if required. Seem reasonable? |
I'm a little confused. What I understood:
c) Make our getValues methods use the new Oversampling features but ignore the oversampling parameter for older model scopes. |
Taken from the ps6000pg manual section 3.6
I think this will fix the issue with the ps5000a not having a oversampling feature.
The text was updated successfully, but these errors were encountered: