Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix failing CI actions #88

Closed
colinodell opened this issue Oct 7, 2023 · 6 comments · Fixed by #89
Closed

Fix failing CI actions #88

colinodell opened this issue Oct 7, 2023 · 6 comments · Fixed by #89

Comments

@colinodell
Copy link
Owner

Our CI tests are currently failing. They used to pass, so I'm guessing we might be relying on versions of something(s) that are too old and no longer supported? I'm not sure, but we should probably fix these so they pass once again.

@navdiya-nikunj
Copy link

Hello @colinodell 👋 can i work on this? I'll try to solve it.

@colinodell
Copy link
Owner Author

Sure!

@Anurag-Nagpal
Copy link
Contributor

Hi @colinodell, I have made some changes to fix the CI actions, I see this issue has been assigned before while I was working on my changes. Let me know if you want to review and merge that PR #89

@colinodell
Copy link
Owner Author

Hi @Anurag-Nagpal, sure, I'll merge your MR :)

@navdiya-nikunj if you're still looking for something to do, maybe you could add newer versions of Python to the build matrix, and resolve any issues that come up? Let me know if that's something you might be interested in (and no worries if not!)

@colinodell colinodell linked a pull request Oct 8, 2023 that will close this issue
@navdiya-nikunj
Copy link

navdiya-nikunj commented Oct 9, 2023

I would love to do that. Thanks @colinodell

Actually I am new to open source so I just want to confirm that you want to test this project using python 3.10 and 3.11 and if any error occurs I have to resolve it right?

@colinodell
Copy link
Owner Author

Yes, exactly! And if you encounter any errors you can't fix, let us know and we will try to help :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants