Skip legacy entry_point tests on Python 3.13+ #679
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These tests require pkg_resources, which was removed in Python 3.13.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #679 +/- ##
=======================================
Coverage 87.28% 87.28%
=======================================
Files 68 68
Lines 3949 3949
Branches 760 760
=======================================
Hits 3447 3447
Misses 396 396
Partials 106 106 ☔ View full report in Codecov by Sentry. |
nuclearsandwich
approved these changes
Nov 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These tests require pkg_resources, which was removed in Python 3.13.
Note that the
entry_pointAPI has been deprecated since #562 and is no longer used in any colcon packages maintained here.