Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BcpsBranchStrategy copy constructor #4

Open
aykutbulut opened this issue Jan 31, 2016 · 0 comments
Open

BcpsBranchStrategy copy constructor #4

aykutbulut opened this issue Jan 31, 2016 · 0 comments
Assignees
Labels

Comments

@aykutbulut
Copy link
Member

BcpsBranchStrategy::clone is pure virtual. A derived class (DcoBranchStrategyRel for example) should implement it. For this base class data should also be copied. But base class (BcpsBranchStrategy) does not provide copy constructor nor copy assignment operator.

Since there is no explicit copy constructor, derived classes use compiler defined copy constructor (which only copies the fields of BcpsBranchStrategy). I think this will cause buggy software. BcpsBranchStrategy should have explicit copy constructor and assignment operator.

Aykut

@tkralphs tkralphs self-assigned this Jul 30, 2019
@tkralphs tkralphs added the bug label Jul 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants