feat: Add support for global deployment file #15
Conversation
Seems less confusing as "local" also has the meaning as in "local" vs. "remote"
| -- get the remote path for rsync | ||
| -- @param local_path string | ||
| -- @return string | ||
| ---get the remote path for rsync |
There was a problem hiding this comment.
What is the reason to change comment style?
There was a problem hiding this comment.
I am using Treesitter parser luap for lua docstrings and they are only highlighted when using ---:
I can revert it if you want though
There was a problem hiding this comment.
This is a bug in your highlighting. Treesitter itself and other popular lua plugins use --space in their codebase.
| -- convert the given local absolute path to a relative project root path | ||
| -- @param absolute_path string | ||
| -- @return string | ||
| ---convert the given local absolute path to a relative project root path |
There was a problem hiding this comment.
Let's keep the format "-- comment", not "---comment"
|
Tbh, I didn't think that this would require so many changes to the codebase 😅. Not sure if I can finish this as I am not too knowledgeable with the existing code base regarding the path handling in |
|
I will close this PR, if someone else wants to implement this feature, feel free to do so using my code |
Still WIP, feedback appreciated.
Closes #14.