Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scrolled themes depend on Sprockets files #2099

Open
tf opened this issue Apr 26, 2024 · 0 comments
Open

Scrolled themes depend on Sprockets files #2099

tf opened this issue Apr 26, 2024 · 0 comments
Labels

Comments

@tf
Copy link
Member

tf commented Apr 26, 2024

Currently when adding a theme for Pageflow Scrolled, we still need to provice an SCSS stylesheet, logo and preview images (app/assets/stylesheets/pageflow/themes/<theme_name>.scss, app/assets/images/pageflow/themes/<theme_name>/logo_print.png, app/assets/images/pageflow/themes/<theme_name>/preview{,_thumbnail}.png) in Sprockets since the editor seed data and the structured data helper still depend on those. The Pageflow engine also registers unused theme stylesheets for asset pipeline precompilation.

We need to consider ways to decouple this further.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant